Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply easy module updates #333

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Apply easy module updates #333

merged 3 commits into from
Aug 24, 2023

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 31, 2023 •
edited
Loading

Some other module updates are available, but those will require changes to the pipeline code.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@ewels
Apply easy module updates
e048710 
Some other module updates are available, but those will require changes to the pipeline code.
@ewels ewels mentioned this pull request Jul 31, 2023
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit b58eb2a

+| ✅ 155 tests passed       |+
#| ❔   3 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-24 12:44:58

edmundmiller
edmundmiller approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are a few other modules to update, it looks like from the linting!

@ewels
Copy link
Member Author

ewels commented Jul 31, 2023

Yup, hence my comment on the PR 😊

@ewels
Copy link
Member Author

ewels commented Jul 31, 2023

Depends on #329 to get the CI to pass

@edmundmiller edmundmiller added this to the 2.5.0 milestone Aug 24, 2023
@edmundmiller edmundmiller merged commit 76ef5de into nf-core:dev Aug 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

@njspix njspix Awaiting requested review from njspix

Assignees

@ewels ewels

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewels @edmundmiller @sateeshperi