-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sed regex for version reporting in pigz modules #6878
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a stub test to this module?
Also, make sure to ask to be added to the nf-core GitHub organisation so you can run the GitHub actions :)
@fellen31 Thanks for the reply. I'm still new to contributing to nf-core, but I'm more than happy to help with adding tests. Could you either point me to some examples of how to add tests for this? |
Sure. You would be adding another test identical the current one but with For a simple example: https://github.com/nf-core/modules/blob/3abde3de0970781e8e9aeec3cfeed759008a6ef4/modules/nf-core/unzip/tests/main.nf.test |
@fellen31 I think it's all in order now. Except for one linting test failing for a different module. Not sure why/how that get's included in these tests. Is the typical procedure that I would also fix the linting for that module or is this typically still merged because I did not make any changes to those module files? Thanks again for pointing me in the right direction! |
No you don't need to fix the others. When you update this branch with the latest master, the other test should not be removed from the list of checks. There was a problem with GitHub Actions earlier today, maybe something is still not working correctly. |
Or actually, in this case it's because |
Co-authored-by: Felix Lenner <[email protected]>
Looking into tcoffee/irmsd, it needs the added types and descriptions in the yaml file. However, while I can 'guess' the types based on the nextflow code, I have no idea what the descriptions should be. So perhaps this is better that someone adds it who actually uses this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the stub test, looks good to me! 👍
Perhaps guessing a bit is ok here, or maybe @luisas could help. I think the linting has been updated to include more checks since that module was added. |
Alright, I've added the types and some general descriptions. Feel free to make adjustments @luisas |
Missing backslash in pigz uncompress stub results in
unknown recognition error type: groovyjarjarantlr4.v4.runtime.LexerNoViableAltException
Simplified sed regex to circumvent the missing/added trailing backslash
PR checklist
Closes #6877