-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call empty droplets #81
Comments
See comments by Rob Patro on Slack: |
Is this related to what's happening in PR #153 ? |
Hi all- FYI there is an 'dropletutils-scripts' package in Bioconda that will provide a container to do this already. The scripts themselves are here: https://github.com/ebi-gene-expression-group/dropletutils-scripts Here's Nextflow process that uses it (admittedly DSL1). Just thought I'd point this out- might be a shortcut to a module. |
I will re-start the PR that has been on work on that since it was too problematic. Using this, we were able to have it in a private copy of the pipeline. I can then work in bringing the script and the module to here. |
I have a PoC running for the main aligners. Once I figure it out for |
PR merged |
Is your feature request related to a problem? Please describe
I think it could be nice to have a step to distinguish empty droplets from actual cells.
As far as I know, Alevin/Kallisto only perform cell calling based on "knee plots", while cellranger implements the emptyDrops algorithm. According to the emptyDrops paper the method clearly outperforms filtering based on knee plots.
Describe the solution you'd like
Implement a process downstream of the aligner subworkflows running the emptyDrops algorithm.
Describe alternatives you've considered
This kind of filtering could be left to downstream pipelines such as #scflow.
However, IMO, it would still make sense to have this as a default even when not using scflow for downstream analysis.
Additional context
STARsolo implements the emptydrops algorithm as of version 2.7.8a which can be activated using the
--soloCellFilter EmptyDrops_CR
option: https://github.com/alexdobin/STAR/blob/master/docs/STARsolo.md#emptydrop-like-filteringI don't know if
emptyDrops
is still state-of-the-art of if there's something more advanced by now.The text was updated successfully, but these errors were encountered: