Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting fails to execute if "----" present in module patch diff file #3281

Open
znorgaard opened this issue Nov 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@znorgaard
Copy link

Description of the bug

Linting will fail to run if "----" is present in a module patch diff file.

Image

In an nf-core pipeline that currently passes linting add one of the latest samtools modules.

nf-core modules install samtools/dict

Modify the environment.yaml file to use a name: and remove the schema reference, because without non-unique conda environments currently break nextflow (until the next release at least). nextflow-io/nextflow#5489

name: samtools_dict
channels:
  - conda-forge
  - bioconda
dependencies:
  - bioconda::htslib=1.21
  - bioconda::samtools=1.21

Linting should still complete successfully at this point.

nf-core pipelines lint

Be responsible, document your patch! Run

nf-core modules patch samtools/dict

Now run linting again.

nf-core pipelines lint
ERROR    not enough values to unpack (expected 2, got 1)

If you remove the "----" line from the diff file, linting will pass again.

Command used and terminal output

System information

Nextflow version: 24.04.4
Hardware: Desktop
Executor: NA
OS: macOS
nf-core/tools version: 3.0.2
python version: 3.12

@znorgaard znorgaard added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant