New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checklist to update maintainers team #2584

Merged

christopher-hakkaart merged 19 commits into main from maintainers_team_updates

Nov 15, 2024

+153 −0

Contributor

edmundmiller commented Jun 17, 2024 •

edited by nf-core-bot

Loading

chore: Add Slack Message from @jfy133
Try to use fancy checklists

@netlify /docs/checklists/maintainers_team_updates

edmundmiller and others added 2 commits

June 17, 2024 15:32


          chore: Add Slack Message from @jfy133

ca55544

Co-authored-by: jfy133 <[email protected]>


          Try to use fancy checklists

8688c0c

edmundmiller self-assigned this

netlify bot commented Jun 17, 2024 •

edited

Loading

✅ Deploy Preview for nf-core-main-site ready!

Name	Link
🔨 Latest commit	`d797082`
🔍 Latest deploy log	https://app.netlify.com/sites/nf-core-main-site/deploys/673705e07ac2cf000802bb5f
😎 Deploy Preview	https://deploy-preview-2584--nf-core-main-site.netlify.app/docs/checklists/maintainers_team_updates
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

edmundmiller requested a review from jfy133

June 17, 2024 20:37

Member

jfy133 commented Jun 18, 2024

@edmundmiller I don't seem to be able to find the page (either by clicking through the website or guessing the URL), any ideas?

Member

jfy133 commented Jun 18, 2024

Oh, wait found it!

jfy133 approved these changes

View reviewed changes

Member

jfy133 left a comment

LGTM but I sort of wonder if it makes sense to have this page exposed in the docs overview page... It's only basically for 3 people +maybe the maintainers team in an an emergency (technically)

src/content/docs/checklists/maintainers_team_updates.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/maintainers_team_updates.mdx Outdated Show resolved Hide resolved

Contributor

mashehu commented Jun 18, 2024

LGTM but I sort of wonder if it makes sense to have this page exposed in the docs overview page... It's only basically for 3 people +maybe the maintainers team in an an emergency (technically)

Yeah, had the same feeling...

Member

jfy133 commented Jun 18, 2024

Can we leave the file in the same place but not index it in the docs overview section @mashehu ? Like 'hidden: true' in the header or something?

Contributor

mashehu commented Jun 18, 2024

We don't have that option, not sure if we really want to have hidden files...

Member

jfy133 commented Jun 18, 2024 •

edited

Loading

Hidden only from being displayed in the overview, not that the page isn't accessible at all (in case I wasn't clear)

Contributor Author

edmundmiller commented Jun 18, 2024

Hidden only from being displayed in the overview, not that the page isn't accessible at all (in case I wasn't clear)

Yeah, I agree with this. I don't think there's anything sensitive in there, but it would just be clutter that most people won't ever need.

Member

jfy133 commented Nov 4, 2024

Whelp forgot about this, what about a section under 'Guidelines' called 'Governance', allows transprency but not something someone would normally click on

jfy133 added 4 commits

November 9, 2024 11:34


          Apply suggestions from code review

d8a07c1


          Restructure, add core team docs too

3fdfc47


          Finish transfer for core-team tasks

c04f403


          Merge branch 'maintainers_team_updates' of https://github.com/nf-core…

a17b4be

…/website into maintainers_team_updates

sateeshperi reviewed

View reviewed changes

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved


          Apply suggestions from code review

bcaf5c7

Co-authored-by: Sateesh_Peri <[email protected]>

Member

jfy133 commented Nov 9, 2024

@nf-core-bot fix linting


          Merge branch 'main' into maintainers_team_updates

5b58fb9

github-actions bot deleted a comment from netlify bot


          [automated] Fix code linting

df436ad

sateeshperi reviewed

View reviewed changes

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

sateeshperi approved these changes

View reviewed changes


          Update src/content/docs/checklists/community_governance/core_team.mdx

17f6da7

Co-authored-by: Sateesh_Peri <[email protected]>

christopher-hakkaart requested changes

View reviewed changes

Member

christopher-hakkaart left a comment

It looks pretty good to me. A few minor comments to remove excess words.

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

jfy133 marked this pull request as ready for review

November 13, 2024 06:01

jfy133 requested a review from a team as a code owner

November 13, 2024 06:01

jfy133 requested a review from vdauwera

November 13, 2024 06:01


          Apply suggestions from code review

40fe9f2

Co-authored-by: Christopher Hakkaart <[email protected]>

jfy133 requested a review from christopher-hakkaart

November 13, 2024 06:02


          Merge branch 'main' into maintainers_team_updates

2ff5db3

christopher-hakkaart requested changes

View reviewed changes

Member

christopher-hakkaart left a comment

I'd like to trend towards some consistent stylistic changes. Content is the same. Please check formatting of the notes I added.

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/core_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved

christopher-hakkaart added 2 commits

November 14, 2024 15:31


          Apply suggestions from code review

6dba19d


          Apply suggestions from code review

b896394

christopher-hakkaart requested changes

View reviewed changes

src/content/docs/checklists/community_governance/maintainers_team.mdx Outdated Show resolved Hide resolved


          Update src/content/docs/checklists/community_governance/maintainers_t…

e4ab405

…eam.mdx

christopher-hakkaart approved these changes

View reviewed changes

christopher-hakkaart added 4 commits

November 15, 2024 08:21


          Linter

0f8e83c


          Move to docs folder

07438b3


          Final review with preview

1b1e11e


          Final review with preview again

d797082

christopher-hakkaart merged commit b37dd78 into main

13 checks passed

christopher-hakkaart deleted the maintainers_team_updates branch

November 15, 2024 11:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

christopher-hakkaart christopher-hakkaart approved these changes

sateeshperi sateeshperi approved these changes

jfy133 jfy133 approved these changes

vdauwera Awaiting requested review from vdauwera vdauwera was automatically assigned from nf-core/docs

Labels

None yet