Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title tag in search and not found pages #54

Open
oss6 opened this issue May 10, 2020 · 1 comment
Open

Title tag in search and not found pages #54

oss6 opened this issue May 10, 2020 · 1 comment
Assignees
@dragondave

Comments

@oss6
Copy link

oss6 commented May 10, 2020

Hi, just a very minor note that the search and not found pages have the following title - NHSX.
For example, for search something like Search - NHSX would be good.
Thanks!
@oss6 oss6 changed the title Title tag in search page and not found page Title tag in search and not found pages May 10, 2020
@dragondave dragondave self-assigned this Apr 15, 2021
@dragondave
Copy link
Contributor

Just fixed Search in development.
Fixing this for the 404 page is surprisingly complicated: there's no easy way for the CMS to provide a title for the 404 page (since it doesn't exist) and the template creating the title tag is used by every page on the site, so needs looking at more carefully.

Leaving this open, might come back to it later.

Thank you for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dragondave dragondave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dragondave @oss6