Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add support to enable source waveform file loading in TestStandSteps.dll's SetupNIDigitalPatternInstrumentation() method #149

Open
SAntonya-NI opened this issue Nov 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@SAntonya-NI
Copy link

SAntonya-NI commented Nov 4, 2024

Currently, SetupNIDigitalPatternInstrument() method doesn't load any source waveform file to 6570/1's memory, because the method doesn't populate low level implemented flag to higher level.

image

Please add support to be able to control this flag from higher level method. Like it's shown below:

image

There is no significant effort is needed here since it is already implemented lower level Initialize (from InstrumentAbstraction.cs) function.

@SAntonya-NI SAntonya-NI added the enhancement New feature or request label Nov 4, 2024
@SAntonya-NI SAntonya-NI changed the title [REQUEST] Add support to enable source waveform file loading in TestStandSteps.dll [REQUEST] Add support to enable source waveform file loading in TestStandSteps.dll's SetupNIDigitalPatternInstrumentation() method Nov 4, 2024
@SAntonya-NI
Copy link
Author

@lornazh @Mattjet27 FYI

@Mattjet27
Copy link
Collaborator

@SAntonya-NI, thank you for raising this request. It is being considered for a future release.

Please note that while the effort to implement this is not significant, it does however require more detailed thought and testing to confirm the appropriate implementation. Care must be taken to ensure adding an optional parameter to the existing method signature does not end up breaking the TestStand Step Type integration installed by the STS Software bundle.

@SAntonya-NI
Copy link
Author

@Mattjet27 Thanks Matt for looking to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants