Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] UserGuide InstrumentAbstraction.md TSMSessionManager description #173

Open
yanli-dev opened this issue Dec 4, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@yanli-dev
Copy link

Describe the bug
In UserGuide InstrumentAbstraction.md TSMSessionManager description could be confusing.

Querying Sessions
In a given test code module, you should create a new instance of TSMSessionManager at the beginning of your test method and pass it to the ISemiconductorModuleContext object as an input.

ISemiconductorModuleContext object is input to TSMSessionManager.

Also impact https://ni.github.io/semi-test-library-dotnet/UserGuide/InstrumentAbstraction.html

@yanli-dev yanli-dev added the bug Something isn't working label Dec 4, 2024
@Mattjet27
Copy link
Collaborator

@yanli-dev, thank you for pointing this out. I believe the text should've read:

Querying Sessions
In a given test code module, you should create a new instance of TSMSessionManager at the beginning of your test method and pass it the ISemiconductorModuleContext object as an input.

Please confirm this change would address your feedback, and we'll work it in as soon as possible.

@yanli-dev
Copy link
Author

Looks great. Thank you.

@Mattjet27 Mattjet27 added the documentation Improvements or additions to documentation label Dec 23, 2024
@Mattjet27 Mattjet27 changed the title [BUG] UserGuide InstrumentAbstraction.md TSMSessionManager description [Documentation] UserGuide InstrumentAbstraction.md TSMSessionManager description Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants