Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't know if auto mask works well. #471

Open
WonJunPark opened this issue Apr 20, 2023 · 2 comments
Open

I don't know if auto mask works well. #471

WonJunPark opened this issue Apr 20, 2023 · 2 comments

Comments

@WonJunPark
Copy link

WonJunPark commented Apr 20, 2023

#264
In other issues, auto mask is mentioned to summarize the code below.

min_reprojection_loss, idx1 = torch.min(reprojection_loss, dim=1) min_identity_reprojection_loss, idx2 = torch.min(identity_reprojection_loss, dim=1) automask = (min_reprojection_loss < min_identity_reprojection_loss).float() to_optimise2 = min_reprojection_loss * automask

But looking at the results, the two values were different.
line 425, to_optimise2 = [0.2001, 0.4251, 0.0000]
line 439, to_optimise = [0.2001, 0.4251, 0.4891]

I don't understand what the code wrote implicitly.
combined = torch.cat((identity_reprojection_loss, reprojection_loss), dim=1)

image

@daniyar-niantic
Copy link
Collaborator

Sorry, it is unclear what is in the screenshots. Could you share a self-contained code snippet please.

@Shaw-Way
Copy link

Shaw-Way commented Dec 1, 2023

Good question, have you tried which solution works better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants