Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro expansion #254

Open
Jaxon-teBoekhorst opened this issue Sep 17, 2024 · 5 comments
Open

Macro expansion #254

Jaxon-teBoekhorst opened this issue Sep 17, 2024 · 5 comments

Comments

@Jaxon-teBoekhorst
Copy link

When expanding macros from imported files comments also get expanded and break the config

@nickcoutsos
Copy link
Owner

Could you provide an example? I'm not sure precisely what you're working with and how I might reproduce.

@Jaxon-teBoekhorst
Copy link
Author

I think macro is the wrong word, a line with "#define var val // comment" will subtitle both the variable and comment, even mid line

@nickcoutsos
Copy link
Owner

Yeah, the preprocessor's going to do that, it doesn't care about comments. Are you writing it out that way or did a comment line get merged onto a previous line after editing with the app? If you can share the original I might be able to track down the cause and correct it.

Just a heads-up, though, I pretty much can't support preprocessor stuff so if you're relying on that to achieve more complicated keymaps there may not be a great path forward.

@Jaxon-teBoekhorst
Copy link
Author

I was converting from a hand written file, and have since fixed the problem, though though I would submit this as a possible suggestion to improve the experience of doing so

@nickcoutsos
Copy link
Owner

Ah, ok, glad to hear you could resolve it. Unfortunately there's nothing I can do about preventing that as its written. If you've hand written a keymap with a line as you've described then the preprocessor is going to do the substitution regardless of whether you use the keymap editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants