Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message when correct template version does not exist #47

Closed
pjrobertson opened this issue Jan 19, 2019 · 3 comments · May be fixed by #48
Closed

Better message when correct template version does not exist #47

pjrobertson opened this issue Jan 19, 2019 · 3 comments · May be fixed by #48

Comments

@pjrobertson
Copy link

I've been trying to use mautic-whitelabeler, and I kept getting the error Mautic installation not found here..

After doing some debugging, I figured that my mautic installation was fine, but the real reason for the problem was that my version of mautic (2.13.0) was not included in the templates folder for whitelabeler.

I suggest the error message be improved from Mautic installation not found here to something along the lines of Incompatible mautic version XXX. See YYY for list of compatible versions where YYY links to perhaps the templates folder on GitHub. Or perhaps even print out the list of compatible versions to the page.

pjrobertson added a commit to pjrobertson/mautic-whitelabeler that referenced this issue Jan 19, 2019
pjrobertson added a commit to pjrobertson/mautic-whitelabeler that referenced this issue Jan 19, 2019
fixes nickian#47
Also: improve UI and form error checking
@nickian nickian closed this as completed Apr 15, 2019
@pjrobertson
Copy link
Author

Hi @nickian any reason as to why this was closed? It would be great if you could provide an explanation - to help both myself understand and others finding this thread in the future.

Thanks!

@nickian
Copy link
Owner

nickian commented Apr 16, 2019

@pjrobertson sorry for not explaining. v2.0 will now detect the Mautic version and if it's not supported yet, it will tell you. If you try running it on a dev version, it will notify you that dev versions are not supported either.

@pjrobertson
Copy link
Author

pjrobertson commented Apr 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants