Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SweetAlert2: Please inlude Promise polyfill BEFORE including sweetalert2.js if IE10+ support needed. #6

Open
vanboom opened this issue Jul 21, 2017 · 3 comments

Comments

@vanboom
Copy link

vanboom commented Jul 21, 2017

This error occurs when running js enabled specs using poltergeist. I am not able to locate the error in code - possibly it is coming from the rails-assets-sweetalert2 ?

  1. The word inlude is mispelled.
  2. How can we inhibit this warning message, it's clogging up logs.

thanks!

@vanboom
Copy link
Author

vanboom commented Jul 22, 2017

I confirmed that this warning is caused by the rails-assets package.

Remove gem 'rails-assets-sweetalert2', '~> 5.1.1', source: 'https://rails-assets.org' from your Gemfile and include the sweetalerts2 assets in your project directly. https://github.com/limonte/sweetalert2/releases

I am not able to locate the project for rails-assets-sweetalert2 package, not sure who or where it is maintained.

@nicolasblanco
Copy link
Owner

PhantomJS is now deprecated in favour of Chrome Headless:

https://groups.google.com/forum/m/#!topic/phantomjs/9aI5d-LDuNE

@chamnap
Copy link

chamnap commented Aug 14, 2017

@vanboom, I found the solution with phantomjs.

You just need to include es6-promise pollyfill, https://github.com/limonte/sweetalert2#usage. It will fix the problem. If you want to see the source of rails-assets-sweetalert2, run bundle show rails-assets-sweetalert2. I'm using the lastest version of sweetalert2. It looks okay for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants