Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change size limit (default <1mb) #11

Open
ZephD opened this issue Jul 18, 2018 · 4 comments
Open

Ability to change size limit (default <1mb) #11

ZephD opened this issue Jul 18, 2018 · 4 comments

Comments

@ZephD
Copy link

ZephD commented Jul 18, 2018

I often view larger json files and the collapsing of fields is very useful.

@acupoftee
Copy link

acupoftee commented Sep 28, 2019

I worked on a warning for JSON files over 3MB in PR #19 since that was the default shown in the source. I agree that an option to change the size limit would be helpful so I could also work on that customization.

@MandyJCho
Copy link

Is the ability to customize the size limit still being worked on? Would it be possible to consider removing the limitation as well?

@acupoftee
Copy link

acupoftee commented Oct 7, 2019

Is the ability to customize the size limit still being worked on?

Yup!

I agree that the limit should be removed as well. I believe the intent of adding a limit in the original repo had to do with Chrome's caching. It'd be more practical to have no limits for developers to analyze JSON of any size.

@acupoftee
Copy link

If you also want to submit a PR without the limitation that'd work too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants