You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My feeling is that this patch goes against niflib's current design - it feels out of place. We have Get and Set functions for everything else elsewhere.
Could you rewrite it to fit that design?
(The other options is of course simply to make all data public... I'm actually not at all against that, but it would be a completely different library, and a lot of things would need to be readdressed.)
I can't really follow. It is a getter and a setter, and one that is in exactly the same way everywhere, just take GetVertices()/SetVertices(), it's almost a copy'n'paste job here only it's for bone-data. :^)
I don't actually care all that much, but:
Your getter and setter are not symmetric (getter = bone data, setter = vector of weights).
Your getter returns a raw pointer to the data; in other parts of the lib, a copy of the data is returned (IIRC).
The text was updated successfully, but these errors were encountered:
Files require review
Allows access to the Bone-weights.
https://www.dropbox.com/s/s1xk3cq0y281o9w/NiSkinData.cpp.diff?dl=0
https://www.dropbox.com/s/od2qjuiesbz9707/NiSkinData.h.diff?dl=0
My feeling is that this patch goes against niflib's current design - it feels out of place. We have Get and Set functions for everything else elsewhere.
Could you rewrite it to fit that design?
(The other options is of course simply to make all data public... I'm actually not at all against that, but it would be a completely different library, and a lot of things would need to be readdressed.)
I can't really follow. It is a getter and a setter, and one that is in exactly the same way everywhere, just take GetVertices()/SetVertices(), it's almost a copy'n'paste job here only it's for bone-data. :^)
I don't actually care all that much, but:
The text was updated successfully, but these errors were encountered: