Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for static PHP methods doesn't work #309

Open
MxRay opened this issue Mar 22, 2018 · 1 comment
Open

Doc for static PHP methods doesn't work #309

MxRay opened this issue Mar 22, 2018 · 1 comment

Comments

@MxRay
Copy link

MxRay commented Mar 22, 2018

I guess I found similar problem to #276 with a difference that this time docblockr doesn't parse static functions correctly. See gif below:

static

@MoritzKn
Copy link
Collaborator

The regex that parses the function assumes the public keyword to be before static:

var r = '^\\s*(?:(?P<modifier>(?:(?:final\\s+)?(?:public|protected|private)\\s+)?(?:final\\s+)?(?:static\\s+)?))?' +

Feel free to update it and send a PR

dmitrach added a commit to dmitrach/docblockr that referenced this issue Jan 15, 2020
The last pull request fixed (nikhilkalige#348). 
Issue nikhilkalige#309 fixed. The modifiers don't depend from their sequence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants