Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support to remove/undo multiline comment blocks #335

Open
YenHub opened this issue May 1, 2019 · 2 comments
Open

Enhancement: Add support to remove/undo multiline comment blocks #335

YenHub opened this issue May 1, 2019 · 2 comments

Comments

@YenHub
Copy link

YenHub commented May 1, 2019

First, thank you for developing such a super awesome tool - it's genuinely superb!

Forgive me if I've missed anything; I have searched through the documentation and was unable to find any reference to undoing multiline comment blocks generated by docblockr.

It would be super helpful if the comment/uncomment keymap was bound also to multiline comment blocks, allowing you to uncomment when using "Ctrl" (CMD) + "/" to uncomment.

/****************************
#moreWrap {                 *
    position: absolute;     *
    top: 0;                 *
    right: 0;               *
    height: 30px;           *
    line-height: 50px;      *
    width: 30px;            *
    overflow: hidden;       *
    text-indent: 100%;      *
    color: transparent;     *
    white-space: nowrap;    *
    z-index: 3;             *
    cursor:pointer;         *
    padding:2px 2px 0px 0px *
}                           *
 ****************************/

Hopefully I will get some time over the weekend to take a look at forking and trying to make the changes required to generate a pull request.

Before doing so, I thought it sensible to ask about this feature first and also whether you have any suggestions that could help me on my journey making the changes for a pull!

Thanks Nikhil, loving your moves!

@YenHub YenHub changed the title Enhancement: Add support to remove/undo comment blocks Enhancement: Add support to remove/undo multiline comment blocks May 1, 2019
@MoritzKn
Copy link
Collaborator

MoritzKn commented May 1, 2019

Hi @YenHub,
appreciating your enthusiasm! I think I should tell you though that this package isn't really actively maintained anymore. @nikhilkalige isn't doing anything on it anymore and I took over maintenance at some point. But at the moment I don't have much time of it anymore either. However if you submit a PR thats ready to go, I'll try to take a look at it and merge it. That's probably not what you wanted to hear – sorry.

That being said, there is a way to "overload" commands by creating a new command with the same keybinding and then in case you want to "fall through" to the original command calling event.abortKeyBinding(). If you still want to give it a go, I recommend following this approach.

@YenHub
Copy link
Author

YenHub commented May 3, 2019

Hi @MoritzKn,

Thanks for your swift response and kindly providing me with a route to follow!

I'll fork the repo over the weekend and take a deep dive to see whether I am able to produce a clean and robust solution that can deliver this functionality.

Once complete, I'll create a PR and get this over and I'll leave this issue open to document the outcome.

Again, thanks kindly for your return, super helpful!

@YenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants