MacOS CI builder uses C++03 by default. #2520
Milestone
Comments
digit-google
added a commit
to digit-google/ninja
that referenced
this issue
Nov 4, 2024
MacOS CI builders use a compiler which defaults to C++03. Unfortunately, CMakeLists.txt only forces C++11 for libninja, try to force it through CMAKE_CXX_STANDARD. Note a few interesting points: - Tests use GoogleTest which officially *requires* C++14. However, it seems that compiling them with C++03 or C++11 doesn´t seem to be an issue on this platform for now. - To avoid future problems, it might be useful to enforce a separate default of C++14 for test programs. - GoogleTest plans to switch to C++17 in December 2024 [1], [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was found by @sesse in PR #2519, the
CMakeLists.txtonly enforces C++11 forlibninja. Anything else, i.e. theninjabinary and tests are compiled with the compiler's default setting.It looks like this is still C++03 for the MacOS builder, resulting in surprising compilation failures.
The fix is to enforce C++11 as the minimum standard in the CMake configuration step of the corresponding github workflow file.
The text was updated successfully, but these errors were encountered: