Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ByteMatcherCompiler inefficient #6

Open
nishihatapalmer opened this issue Feb 21, 2016 · 0 comments
Open

ByteMatcherCompiler inefficient #6

nishihatapalmer opened this issue Feb 21, 2016 · 0 comments
Labels
test

Comments

@nishihatapalmer
Copy link
Owner

Seems to create the bytematcher only to take the bytes it matches and most often just re-create them. Use of OptimalByteMatcherFactory in ByteMatcherCompiler.

  • Only sets of bytes need to be optimised - the other matchers have definite values and cannot themselves be optimised further.
  • Should only optimise once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nishihatapalmer