Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VSCRIPT] On linux, 'params' is not passed in ModifyEmitSoundParams(handle [params]) #1428

Closed
zeThijs opened this issue Apr 21, 2023 · 3 comments
Closed

[VSCRIPT] On linux, 'params' is not passed in ModifyEmitSoundParams(handle [params]) #1428

zeThijs opened this issue Apr 21, 2023 · 3 comments
Assignees
@felis-catus
Labels
Priority: Minimal These issues are things that are nice to have, but not required for the next release. Status: Completed Type: Code

Comments

@zeThijs
Copy link

zeThijs commented Apr 21, 2023

Works fine in windows, but breaks in linux.
Example code:
entity.ValidateScriptScope()
local scope = entity.GetScriptScope()
scope.ModifyEmitSoundParams <- function()
{
ModEmitSnd_Elite(params)
}

Example error passed into console:
AN ERROR HAS OCCURRED [the index 'params' does not exist]

CALLSTACK
*FUNCTION [unknown()] scriptname.nut line [120]
@felis-catus felis-catus added Status: Reviewed Type: Code Priority: Minimal These issues are things that are nice to have, but not required for the next release. labels Apr 23, 2023
@felis-catus felis-catus added Priority: Normal These issues should be fixed by the next release. Review before next release. and removed Priority: Minimal These issues are things that are nice to have, but not required for the next release. labels Jun 4, 2023
@felis-catus felis-catus added Priority: Minimal These issues are things that are nice to have, but not required for the next release. and removed Priority: Normal These issues should be fixed by the next release. Review before next release. labels Jul 7, 2023
@felis-catus felis-catus self-assigned this Nov 11, 2023
@felis-catus
Copy link
Member

This was fixed in src-r7171.

@zeThijs
Copy link
Author

zeThijs commented Dec 2, 2023

nice!

@samisalreadytaken
Copy link

@felis-catus This is also being tracked here mapbase-source/source-sdk-2013#244, you should consider contributing the fix upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felis-catus felis-catus

Labels
Priority: Minimal These issues are things that are nice to have, but not required for the next release. Status: Completed Type: Code
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felis-catus @samisalreadytaken @zeThijs