Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists needs a fix for some hardcoded flags #547

Open
barracuda156 opened this issue Mar 19, 2024 · 2 comments · May be fixed by #550
Open

CMakeLists needs a fix for some hardcoded flags #547

barracuda156 opened this issue Mar 19, 2024 · 2 comments · May be fixed by #550

Comments

@barracuda156
Copy link

Some of the hardcoded flags here are wrong: https://github.com/nmslib/hnswlib/blob/master/CMakeLists.txt

  1. -march= is not supported on PowerPC, -mtune= is.

  2. -lrt is a BSD library, it should not be used on macOS, AFAIK.
@yurymalkov
Copy link
Member

Hi @barracuda156,
Can you please fix it wit a PR (and maybe test)?

barracuda156 added a commit to barracuda156/hnswlib that referenced this issue Mar 22, 2024
@barracuda156
CMakeLists: fix GCC flags
6d7a5e6 
Fixes: nmslib#547
@barracuda156 barracuda156 linked a pull request Mar 22, 2024 that will close this issue
Open
@barracuda156
Copy link
Author

@yurymalkov Will it run CI here? I will check on macOS locally, but I cannot check it on Linux or BSD.
#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMakeLists: fix GCC flags barracuda156/hnswlib
2 participants
@yurymalkov @barracuda156