Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number only allows for Singapore number. #11

Open
nobodyishappy opened this issue Apr 19, 2024 · 1 comment
Open

Number only allows for Singapore number. #11

nobodyishappy opened this issue Apr 19, 2024 · 1 comment

Comments

@nobodyishappy
Copy link
Owner

nobodyishappy commented Apr 19, 2024

image.png

What if the user that you are trying to add in from another country and does not have a Singapore number? For example, he is a international student that is just here for exchange.

@nus-se-bot
Copy link

nus-se-bot commented Apr 22, 2024

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number restriction is restrictive for international users.

Description: According to the user guide, the value proposition is that "CCA Manager is a contact manager designed to simplify the management of CCAs and enhance your administrative efficiency, regardless of whether you're overseeing a sports team, academic club, any other extracurricular activity, or simply a CCA participant," where it does not specify that this produce is specifically for the schools in Singapore, nor it is stated in the UG/DG as a restriction. As an international student from South Korea, I want to manage the CCA and members with this product but it disallows adding other valid international phone numbers as an input. Since this could hinder the international users / users with different nationality from using this product without stated in the value proposition or restriction in the UG, I classified this as a feature flaw.

Stepts to reproduce: add n/John Doe p/01067136414 e/[email protected] a/6 Sin Ming #1-01 (phone number is valid South Korea's phone number (it is my phone number))

Expected: New person added (with the details on this person)

Actual: Phone numbers should only contain numbers, and it should be 8 digits long according to Singapore mobile number format which starts with 8 or 9.

Screenshot 2024-04-19 at 4.35.49 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#1473] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did not emphasize that phone numbers have to be Singaporean phone number that starts with either 8 or 9 in our UG

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants