Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly strict sharktank version dependencies #459

Open
saienduri opened this issue Nov 8, 2024 · 1 comment
Open

Overly strict sharktank version dependencies #459

saienduri opened this issue Nov 8, 2024 · 1 comment

Comments

@saienduri
Copy link
Contributor

saienduri commented Nov 8, 2024

Using the latest SHARK-Platform, ran into this error when trying to use it in other projects:

image

Might be worth to not set such strict requirements on things like huggingface-hub if users start trying to integrate SHARK-Platform with their own projects.

Text:

ERROR: Cannot install -r models/requirements.txt (line 18), -r models/requirements.txt (line 3) and -r models/requirements.txt (line 7) because these package versions have conflicting dependencies.

The conflict is caused by:
    diffusers 0.29.0.dev0 depends on huggingface-hub>=0.23.2
    transformers 4.37.1 depends on huggingface-hub<1.0 and >=0.19.3
    sharktank 2.9.0.dev0 depends on huggingface-hub==0.22.2

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict
@ScottTodd
Copy link
Member

Version pins are in https://github.com/nod-ai/SHARK-Platform/blob/main/sharktank/requirements.txt . Some prior discussion about pinning exact versions vs ranges is on #440

Can you copy the text from that screenshot so it is searchable?

@ScottTodd ScottTodd changed the title Overly Strict Version Dependencies Overly strict sharktank version dependencies Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants