You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Hi! I investigated migrating a few of these tasks (specifically, the tasks related to running the test suites) this weekend and have a few notes I just thought I'd share:
Running the unit tests is easy enough. We can almost just copy the existing make targets into npm scripts: see a couple examples here on a branch: master...pstephenson02:dev/npm-scripts-testing
However: Running the web driver tests is a bit more complicated. The Makefile first concatenates a few of the tests and then browserify's them for web driver use. The issue though, if you noticed in my branch above, is that the specific web driver tests are defined in the Makefile. Npm scripts does allow you to define variables in the config section, but it does not support arrays. So we'd need to either delegate running phantom to some util module that has those test files defined/configured, or modify the tests directory and separate the web driver tests.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As of this writing we're using a makefile to build this project. However, we agree that a makefile build isn't particularly "node-like"—so let's consider alternatives!
@cdaringe @paulcpederson
The text was updated successfully, but these errors were encountered: