Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve windows build by pch #37098

Closed
gengjiawen opened this issue Jan 27, 2021 · 1 comment
Closed

Improve windows build by pch #37098

gengjiawen opened this issue Jan 27, 2021 · 1 comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.

Comments

@gengjiawen
Copy link
Member

This patch bnoordhuis/v8-cmake#43 bring v8 build from 72min to 13min for v8.

I think apply this on our side will make us less suffer dealing with v8 on windows.

Not sure our https://github.com/nodejs/node/blob/master/tools/msvs/pch/v8_pch.h is enabled by default. But our surely take much more time, maybe can fix by add more headers ?

cc @nodejs/v8 @nodejs/platform-windows

@Lxxyx Lxxyx added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform. labels Jan 27, 2021
@StefanStojanovic
Copy link
Contributor

While working on #55249 I stumbled upon this issue

I'm not sure what the situation was like when this was opened, but now, PCH is enabled by default (and will be for ClangCL as well). I tried including headers from the mentioned v8-cmake PR in v8_pch.h, but that did not improve compile time. With all this considered, @gengjiawen can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants