Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: vcbuild format-md doesn't hit all the things #55216

Open
srl295 opened this issue Oct 1, 2024 · 1 comment
Open

build: vcbuild format-md doesn't hit all the things #55216

srl295 opened this issue Oct 1, 2024 · 1 comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@srl295
Copy link
Member

srl295 commented Oct 1, 2024

Summary

vcbuild.bat format-md did not reformat .\doc\contributing\maintaining\maintaining-icu.md

Repro

My PR said to run format-md, so:

PS C:\Users\srl29\src\node> .\vcbuild.bat format-md
Running Markdown formatter on docs...
PS C:\Users\srl29\src\node> git status
On branch fix-icu-windows-configure-55214
Your branch is up to date with 'srl295/fix-icu-windows-configure-55214'.

nothing to commit, working tree clean

Investigating, found that format-md only hits doc\*.md.

Workaround

PS C:\Users\srl29\src\node> out\release\node.exe .\tools\lint-md\lint-md.mjs --format .\doc\contributing\maintaining\maintaining-icu.md             
@srl295 srl295 added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 1, 2024
@srl295
Copy link
Member Author

srl295 commented Oct 1, 2024

fyi @StefanStojanovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

1 participant