From 7e593275025946f062c83fe75c705f196ac532bc Mon Sep 17 00:00:00 2001
From: "Kevin Ransom (msft)" <codecutter@hotmail.com>
Date: Tue, 28 May 2024 11:21:50 -0700
Subject: [PATCH] Fix AOT (#17238)

---
 azure-pipelines.yml                                  |  2 +-
 eng/Build.ps1                                        | 12 ------------
 .../Microsoft.FSharp.Compiler.fsproj                 |  3 ---
 tests/AheadOfTime/check.ps1                          |  8 ++++++++
 4 files changed, 9 insertions(+), 16 deletions(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index e0c4349b26b..d75d8401c03 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -128,7 +128,7 @@ extends:
             - script: eng\CIBuild.cmd
                       -configuration $(_BuildConfig)
                       -prepareMachine
-                      -testAllButIntegrationAndAot
+                      -testAllButIntegration
                       -officialSkipTests $(SkipTests)
                       /p:SignType=$(_SignType)
                       /p:DotNetSignType=$(_SignType)
diff --git a/eng/Build.ps1 b/eng/Build.ps1
index 5f426f474f9..6d4bff3a4e7 100644
--- a/eng/Build.ps1
+++ b/eng/Build.ps1
@@ -61,7 +61,6 @@ param (
     [switch]$testVs,
     [switch]$testAll,
     [switch]$testAllButIntegration,
-    [switch]$testAllButIntegrationAndAot,
     [switch]$testpack,
     [switch]$testAOT,
     [switch]$testBenchmarks,
@@ -105,7 +104,6 @@ function Print-Usage() {
     Write-Host "Test actions"
     Write-Host "  -testAll                      Run all tests"
     Write-Host "  -testAllButIntegration        Run all but integration tests"
-    Write-Host "  -testAllButIntegrationAndAot  Run all but integration and AOT tests"
     Write-Host "  -testCambridge                Run Cambridge tests"
     Write-Host "  -testCompiler                 Run FSharpCompiler unit tests"
     Write-Host "  -testCompilerService          Run FSharpCompilerService unit tests"
@@ -172,19 +170,9 @@ function Process-Arguments() {
         $script:testAOT = $True
     }
 
-    if($testAllButIntegrationAndAot) {
-        $script:testDesktop = $True
-        $script:testCoreClr = $True
-        $script:testFSharpQA = $True
-        $script:testIntegration = $False
-        $script:testVs = $True
-        $script:testAOT = $False
-    }
-
     if ([System.Boolean]::Parse($script:officialSkipTests)) {
         $script:testAll = $False
         $script:testAllButIntegration = $False
-        $script:testAllButIntegrationAndAot = $False
         $script:testCambridge = $False
         $script:testCompiler = $False
         $script:testCompilerService = $False
diff --git a/src/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.fsproj b/src/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.fsproj
index a33eeaa8d39..86cf404db69 100644
--- a/src/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.fsproj
+++ b/src/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.fsproj
@@ -48,9 +48,6 @@
     <DependentProjects Include="$(MSBuildThisFileDirectory)..\Compiler\FSharp.Compiler.Service.fsproj">
         <AdditionalProperties>TargetFrameworks=netstandard2.0</AdditionalProperties>
     </DependentProjects>
-    <DependentProjects Include="$(MSBuildThisFileDirectory)..\Compiler\FSharp.Compiler.Service.fsproj">
-        <AdditionalProperties>TargetFrameworks=netstandard2.0</AdditionalProperties>
-    </DependentProjects>
   </ItemGroup>
 
    <ItemGroup>
diff --git a/tests/AheadOfTime/check.ps1 b/tests/AheadOfTime/check.ps1
index e8fd72b57e5..2edefd41f2b 100644
--- a/tests/AheadOfTime/check.ps1
+++ b/tests/AheadOfTime/check.ps1
@@ -1,4 +1,12 @@
 Write-Host "AheadOfTime: check1.ps1"
 
+# the NUGET_PACKAGES environment variable tells dotnet nuget where the global package is
+# So save the current setting, we'll reset it after the tests are complete
+# Then clear the global cache so that we can grab the FSharp.Core nuget we built earlier
+$savedNUGET_PACKAGES=$env:NUGET_PACKAGES
+$env:NUGET_PACKAGES=Join-Path $PSScriptRoot "../../artifacts/nuget/AOT/"
+dotnet nuget locals global-packages --clear
+
 Equality\check.ps1
 Trimming\check.ps1
+$env:NUGET_PACKAGES=$savedNUGET_PACKAGES