Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signing ID to the Text / Syslog logs #137

Open
pmarkowsky opened this issue Nov 15, 2024 · 1 comment
Open

Add Signing ID to the Text / Syslog logs #137

pmarkowsky opened this issue Nov 15, 2024 · 1 comment
Milestone

Comments

@pmarkowsky
Copy link
Contributor

Currently Santa does not log the Signing ID or Team ID in the text logs meaning that you can only get to them if you use the json or protobuf output.

This should be put behind a configuration option as we know there are users that are parsing the syslogs directly.

@pmarkowsky pmarkowsky added this to the 2025.1 milestone Nov 15, 2024
@mlw
Copy link
Contributor

mlw commented Nov 15, 2024

For some context - there are a large number of fields in the protobuf schema that are not contained in the file/syslog logs. This was done historically for a few of reasons:

  1. To not unintentionally break compatibility. Santa log output followed a standard, but was undocumented. There was concern that not all parsers would properly handle changes to the output. To be conservative and not break users, new fields were often not added.
  2. When streaming, syslog lines are capped to a maximum line length. To prevent lost data due to overflow, data included in the lines was kept more minimal
  3. Structured logging via protobuf is much more easily consumed, has built in parsers, and much better type safety. The general feeling is that consumers should be migrating to protobuf as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants