-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS doesn't redraw while window resize is held but not moving #455
Comments
I think this is relevant: |
So the general issue seems to be that when If you re-add the draw timer from before #443, but set the mode to I'm not sure how |
@markmurphydev, I wrote new implementation (basically copied it from android and ios) |
I noticed that the window also freezes while any drop-down on the osx top menu bar is open, but this is also fixed by #462 |
- Reverted macos.rs to this implementation: not-fl3#443 (it's probably better compare changes with this PR than with latest commit to understand what was added additionally) - Now using own NSView with NSOpenGLContext instead of NSOpenGLView - For metal backend using redraw instead setNeedsDisplay, because somehow it reduces cpu usage (Cannot find info about enabling vsync like this in MTKView docs) - Fixed freezing on resize by drawing in draw_rect that called during "live resize"™. I don't like this approach, but it blocks main event loop while resizing, so it will not be some kind of concurency of opengl stuff i think - Reducing CPU usage when window is occluded - Added comments to hacky places, there are lots of them imo Fixes: - not-fl3#455 - not-fl3#470
- Reverted macos.rs to this implementation: #443 (it's probably better compare changes with this PR than with latest commit to understand what was added additionally) - Now using own NSView with NSOpenGLContext instead of NSOpenGLView - For metal backend using redraw instead setNeedsDisplay, because somehow it reduces cpu usage (Cannot find info about enabling vsync like this in MTKView docs) - Fixed freezing on resize by drawing in draw_rect that called during "live resize"™. I don't like this approach, but it blocks main event loop while resizing, so it will not be some kind of concurency of opengl stuff i think - Reducing CPU usage when window is occluded - Added comments to hacky places, there are lots of them imo Fixes: - #455 - #470
Running the Quad example on MacOS on master, the window does not draw while the corner is held, but does draw while dragging it around to resize.
miniquad_quad.mov
This was introduced in #443
The text was updated successfully, but these errors were encountered: