Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default host name #27

Open
clairernovotny opened this issue Dec 5, 2019 · 0 comments
Open

Override default host name #27

clairernovotny opened this issue Dec 5, 2019 · 0 comments

Comments

@clairernovotny
Copy link
Collaborator

clairernovotny commented Dec 5, 2019

We should do something like this by default to "do the right thing." We already hash user id, we should do the same for the roleinstance/name to prevent possible PII in the name.

// override capture of the hostname
// https://github.com/Microsoft/ApplicationInsights-dotnet/blob/80025b5d79cc52485510d422cfa5a0a8159dac83/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L544
 _client.Context.Cloud.RoleInstance = "Git Extensions";
_client.Context.Cloud.RoleName = "Git Extensions";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant