Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX 20: NX DevKit Undocumented Breaking Change #28461

Open
2 of 4 tasks
gcko opened this issue Oct 16, 2024 · 0 comments
Open
2 of 4 tasks

NX 20: NX DevKit Undocumented Breaking Change #28461

gcko opened this issue Oct 16, 2024 · 0 comments

Comments

@gcko
Copy link

gcko commented Oct 16, 2024

Documentation issue

  • Reporting a typo
  • Reporting a documentation bug
  • Documentation improvement
  • Documentation feedback

Is there a specific documentation page you are reporting?

https://nx.dev/deprecated

Additional context or description

With the update to NX 20, any existing plugins that still make use of workspace in the ExecutorContext will now break. Although this has been marked as deprecated in the codebase since NX 16, it was not publicly disclosed in the NX 20 Release announcements and it does not show up in the deprecated section.

Link to Blame information: https://github.com/nrwl/nx/blame/d131b0b67709560d816b0df394c762e72a7b51d6/packages/nx/src/config/misc-interfaces.ts#L248-L253C60

For reference, this is what was removed

/**
   * Deprecated. Use projectsConfigurations or nxJsonConfiguration
   * The full workspace configuration
   * @todo(vsavkin): remove after v17
   */
  workspace?: ProjectsConfigurations & NxJsonConfiguration;

This caused an unexpected failure of at least one plugin that I am aware of: koliveira15/nx-sonarqube#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant