Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect: Support versioned signature schemes #531

Open
cthulhu-rider opened this issue Nov 9, 2023 · 2 comments
Open

WalletConnect: Support versioned signature schemes #531

cthulhu-rider opened this issue Nov 9, 2023 · 2 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular

Comments

@cthulhu-rider
Copy link
Contributor

Context

NeoFS supports WalletConnect signature scheme implemented here. It was added almost 2y ago and follows algo from neon-js lib of those days

since then neon-js library has moved forward, and, starting from this, now it supports multiple signature versions

Proposal

version the signature scheme similarly to neon-js: add the version to the signature and use it during verification. Missing token will still be treated as legacy schema

@cthulhu-rider cthulhu-rider added the enhancement Improving existing functionality label Nov 9, 2023
@roman-khimov
Copy link
Member

signMessageNew() looks interesting, signing arbitrary data without any prefixes/suffixes.

@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I3 Minimal impact labels Dec 20, 2023
@roman-khimov
Copy link
Member

It still adds some salt though. And there is also signMessageWithoutSalt provided by DAPI that doesn't do that, but it adds prefix (010001f0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants