Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try not to use any interface as a generalization #538

Open
carpawell opened this issue Dec 15, 2023 · 0 comments
Open

Try not to use any interface as a generalization #538

carpawell opened this issue Dec 15, 2023 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes performance More of something per second S2 Regular significance U4 Nothing urgent

Comments

@carpawell
Copy link
Member

carpawell commented Dec 15, 2023

Is your feature request related to a problem? Please describe.

I'm always frustrated when I see any keyword when the code needs to do some common actions with the different structs. We have generics for that for more than 1.5 years already. One of such funcs is signing and verification. They are the hot ones in an average NeoFS application so even a small optimization can be good.

Describe the solution you'd like

Try to use generics here. I am not sure it is really possible but still we can try it. Do some benchmarks (but even if the outcome is not that good, I would always prefer a generic version over the any one).

Describe alternatives you've considered

Do nothing.

@carpawell carpawell added enhancement Improving existing functionality research labels Dec 15, 2023
@roman-khimov roman-khimov added U4 Nothing urgent S2 Regular significance I0 Maximum impact performance More of something per second I4 No visible changes and removed research I0 Maximum impact labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes performance More of something per second S2 Regular significance U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants