Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not panic ever in SDK #600

Open
carpawell opened this issue Jul 15, 2024 · 2 comments
Open

Do not panic ever in SDK #600

carpawell opened this issue Jul 15, 2024 · 2 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent

Comments

@carpawell
Copy link
Member

See #390 (comment).
@carpawell carpawell added I2 Regular impact feature Completely new functionality labels Jul 15, 2024
@roman-khimov
Copy link
Member

I think it's too broad. There are valid cases for panics. For example,

https://cs.opensource.google/go/go/+/refs/tags/go1.22.5:src/net/http/server.go;l=1576
https://cs.opensource.google/go/go/+/refs/tags/go1.22.5:src/bytes/bytes.go;l=517

@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S3 Minimally significant I3 Minimal impact and removed I2 Regular impact feature Completely new functionality labels Jul 16, 2024
@carpawell
Copy link
Member Author

There are valid cases for panics

Agree they can appear when nothing can be done or it is a developer error. But we still panic on user's inputs.

@AliceInHunterland AliceInHunterland mentioned this issue Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @carpawell