-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsqd: enable compression/decompression pipeline from producer to consumer #1148
Comments
@ploxiln This will rely on your re-design about the nsq storage backend format. |
Hi @andyxning, thanks for this proposal. I'm trying to understand the motivation here, is it to reduce on-disk and in-memory footprint? Have you considered compressing the data in your producer or consumer instead? Remember, to |
The network bandwidth is reduced, that's the only thing that snappy or deflate compression of the tcp-protocol does.
this is true, the messages are not compressed in memory or on disk, only "over the wire"
TCP protocol consumer is the only kind of consumer. For the producer, the HTTP /pub request could use So what remains is some way for messages to be compressed in memory and disk queues. As @mreiferson says the producer and consumer can be made to use any message format, including compressed, so that's an easy thing a user can do today. I suppose it would be a nice additional feature to optionally have nsqd "take care of it" for the common case of text messages ... and it would be nice to avoid double-compressing messages over the wire (without giving up compression of control frames). I haven't read through and digested the proposal yet ... |
@mreiferson @ploxiln PTAL. |
let's continue this conversation in #1149 |
NSQ currently supports snappy compression and decompression for TCP-protocol based producer and consumer. But it has some shortcomings.
I have made a proposal for this: https://docs.google.com/document/d/107yDH6pN8-b_i22AfvPkzdDU2yneOC-1lcUllpUmN4w/edit#heading=h.tla1oogr3wac
/cc @mreiferson @ploxiln
The text was updated successfully, but these errors were encountered: