Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: panic when nsqd exits #1326

Closed
wangcn opened this issue Mar 16, 2021 · 2 comments · Fixed by #1331
Closed

nsqd: panic when nsqd exits #1326

wangcn opened this issue Mar 16, 2021 · 2 comments · Fixed by #1331
Labels
bug

Comments

@wangcn
Copy link

wangcn commented Mar 16, 2021

How to reproduce?

  1. Pull master branch. The lastest commit is c164c77
  2. Make
  3. Start nsqd
  4. Kill nsqd

It panics and outputs "panic: close of closed channel".

#1319 (comment)
ad73d05#diff-4fb927abdfbf2db38da702b7131f128fa6d7e4cbd3d6d7baa3f4271eb2949956R471
These lines cause nsqd.Exit to be called twice. We can just simply use go-svc to handle all signals.
@mreiferson
Copy link
Member

ping @jehiah

@mreiferson mreiferson added the bug label Mar 21, 2021
@mreiferson mreiferson changed the title pr1319 causes panic when nsqd exits nsqd: panic when nsqd exits Mar 21, 2021
@jehiah jehiah mentioned this issue Mar 23, 2021
Merged
@mreiferson
Copy link
Member

mreiferson commented Mar 28, 2021 •
edited
Loading

This will be fixed in #1331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nsqd: handle repeated calls to Exit() jehiah/nsq
2 participants
@mreiferson @wangcn