Prefer read replicas when choosing nodes to search #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #8610: [Replication] Use secondaries first. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
- Coverage 82.19% 82.17% -0.03%
==========================================
Files 336 336
Lines 19852 19829 -23
==========================================
- Hits 16317 16294 -23
Misses 3535 3535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lferran
reviewed
Jan 25, 2024
lferran
approved these changes
Jan 25, 2024
lferran
reviewed
Jan 29, 2024
lferran
approved these changes
Jan 29, 2024
jotare
force-pushed
the
joanantoniriera4168/sc-8610/replication-use-secondaries-first
branch
from
eb0b38e
to
e721c2e
Compare
jotare
deleted the
joanantoniriera4168/sc-8610/replication-use-secondaries-first
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change logic around
choose_nodeso read replicas are preferred over primary index nodesPotential improvements
With this logic, if we call
choose_node(shard, read_only=True)and there's 1 read replica and 2 primary nodes, searches will always go to the secondary. Maybe a better load balancing can be thought.How was this PR tested?
Unit tests