Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showTimeSelect attribute to NDS DatePicker #1373

Open
2 of 4 tasks
jchunky opened this issue Mar 4, 2024 · 1 comment
Open
2 of 4 tasks

Add support for showTimeSelect attribute to NDS DatePicker #1373

jchunky opened this issue Mar 4, 2024 · 1 comment
Assignees
Labels

Comments

@jchunky
Copy link

jchunky commented Mar 4, 2024

Is your feature request related to a problem? If so, please describe.

We used the ReactDatePicker component in PackManager, rather than the DatePicker from NDS, because we needed to use the showTimeSelect attribute.

See pull request:
https://github.com/nulogy/PackManager/pull/8577/files?w=1#diff-4250fb526ad484447e8865152b6a920b10c0553e168ab8a5f900074d25fc73dcR43

If the NDS DatePicker were updated to support showTimeSelect, then we'd be happy to switch over to the NDS DatePicker.

Is your team blocked from moving forward by the lack of this functionality/behaviour?

SF2 is not blocked, because we're just using ReactDatePicker directly.

Do you have an alternative solution for the problem?

No response

Have you consulted and have an alignment with the product designer?

  • Yes
  • No

Who would you like to execute this feature?

  • Myself
  • DesignOps

When do you need this by?

No rush

Helpful resources

No response

Additional context

No response

@haideralsh
Copy link
Contributor

@nikola-nulogy This issue requires design for the time selector.
image

Without any styles, this is how it looks in NDS:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants