Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for panics and context cancellation scenarios #136

Open
kohlisid opened this issue Jul 11, 2024 · 0 comments
Open

Add tests for panics and context cancellation scenarios #136

kohlisid opened this issue Jul 11, 2024 · 0 comments

Comments

@kohlisid
Copy link
Contributor

          In the current setup, this is difficult to test via UT directly. I tried to add the test there but the assert.Panics (which internally uses recover) was not able to catch it as the panic is invoked from within another goroutine. Would need to research more on how can we cover something like this. In python i'm able to mock the panic and test which wasn't working out here.

I tried few manual scenarios to induce such panics which were working fine.

Originally posted by @kohlisid in #133 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant