Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid installing project specific binaries to system paths #153

Open
BulkBeing opened this issue Sep 23, 2024 · 0 comments
Open

Avoid installing project specific binaries to system paths #153

BulkBeing opened this issue Sep 23, 2024 · 0 comments

Comments

@BulkBeing
Copy link
Contributor

Currently we depend on 3 gRPC specific binaries: protoc-gen-go, protoc-gen-go-grpc and protoc.
We manage the version of protoc-gen-go and protoc-gen-go-grpc in the go.mod file. These binaries are installed if they doesn't already exist in the user's $PATH. If the user has a different version of this binary already installed, the version we specify in the go.mod will not be installed. This creates changes in the code generated from .proto files.

google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0

// - protoc-gen-go-grpc v1.4.0

I think we can install these binaries within a sub-directory of the numaflow-go (e.g., bin/) using the Makefile. The implementation should be easy - the GOBIN can be used to make go install binaries to a custom directory, and the protoc is available as a static binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant