You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we depend on 3 gRPC specific binaries: protoc-gen-go, protoc-gen-go-grpc and protoc.
We manage the version of protoc-gen-go and protoc-gen-go-grpc in the go.mod file. These binaries are installed if they doesn't already exist in the user's $PATH. If the user has a different version of this binary already installed, the version we specify in the go.mod will not be installed. This creates changes in the code generated from .proto files.
I think we can install these binaries within a sub-directory of the numaflow-go (e.g., bin/) using the Makefile. The implementation should be easy - the GOBIN can be used to make go install binaries to a custom directory, and the protoc is available as a static binary.
The text was updated successfully, but these errors were encountered:
Currently we depend on 3 gRPC specific binaries:
protoc-gen-go
,protoc-gen-go-grpc
andprotoc
.We manage the version of
protoc-gen-go
andprotoc-gen-go-grpc
in thego.mod
file. These binaries are installed if they doesn't already exist in the user's$PATH
. If the user has a different version of this binary already installed, the version we specify in thego.mod
will not be installed. This creates changes in the code generated from.proto
files.numaflow-go/go.mod
Line 12 in 39fbfd4
numaflow-go/pkg/apis/proto/map/v1/map_grpc.pb.go
Line 3 in 39fbfd4
I think we can install these binaries within a sub-directory of the
numaflow-go
(e.g.,bin/
) using theMakefile
. The implementation should be easy - theGOBIN
can be used to makego install
binaries to a custom directory, and theprotoc
is available as a static binary.The text was updated successfully, but these errors were encountered: