Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new folders #78

Open
4 of 9 tasks
bilelmoussaoui opened this issue May 17, 2015 · 25 comments
Open
4 of 9 tasks

Adding new folders #78

bilelmoussaoui opened this issue May 17, 2015 · 25 comments
Labels

Comments

@bilelmoussaoui
Copy link
Contributor

bilelmoussaoui commented May 17, 2015

Hello ,
I just wanted to ask if you are going to add some new folders?

  • Android
  • Backup
  • Books folder (alreay reported in Numix base)
  • Github folder
  • GOG Games
  • Movies/Series folder
  • Recording folder
  • Steam folder
  • VirtualBox/Vmware/Gnome Box folder

Thank you for your awesome work !! and i guess this will not be as hard to do as before.

@andia89
Copy link
Contributor

andia89 commented May 17, 2015

The first two are already there!

@bilelmoussaoui
Copy link
Contributor Author

@wa4557 i found only Steam folder, can you please give me the filename of the second one?

@andia89
Copy link
Contributor

andia89 commented May 17, 2015

*-folder-vm.svg

@bilelmoussaoui
Copy link
Contributor Author

Thank you ;)

@Foggalong
Copy link
Contributor

GitHub is a wontfix because it's a bit too specific - we do have Projects and System folders though :) the other are doable though won't be a priority to fulfil. but same as always we'll accept community contributions for any of them!

@andia89
Copy link
Contributor

andia89 commented May 17, 2015

I still want to have and do a books folder. But its a tedious work :(

@andia89
Copy link
Contributor

andia89 commented May 20, 2015

I made book folders cf #79. Since this a hell lot of work I won't make any more :( so if anyone wants to make the movie/series folder fine but since we already have a video folder I suppose this might as well be a wontfix

@bilelmoussaoui
Copy link
Contributor Author

Well, thank you very much for your hardwork 😸 maybe somebody from the community will want to make the others.

@palob
Copy link
Member

palob commented Jul 17, 2015

Now with the custom colour switching implemented in the script are the coloured svgs still needed?
Couldn't we have the predefined colours defined in a csv and have the script create the svgs?

@Foggalong
Copy link
Contributor

The coloured SVGs are needed for Folder-Color support, so no unfortunately :(

@palob
Copy link
Member

palob commented Jul 17, 2015

Ah OK, but at least when doing new folders the coloured ones could be created using the script.

@Foggalong
Copy link
Contributor

It gets a bit complicated if you want to generate some icons from one colour but not others. You could use the script to generate them in the first place but they'd need to stay in the theme afterward

@palob
Copy link
Member

palob commented Jul 17, 2015

Yep, that's what I meant.

@Foggalong
Copy link
Contributor

ooop! sorry, I gotya :P

@bilelmoussaoui
Copy link
Contributor Author

I added Recording folder! if you're a student like me, i do use the gnome recording application to record some courses! helps me a lot

@ghost
Copy link

ghost commented Oct 28, 2015

Would it be possible to add a GOG Games folder ?

It could be a simple folder with the GOG.com logo on it, much like the Steam folder.

@Foggalong
Copy link
Contributor

Yeah, but same as for the others only by user contribution. Too niche to cover otherwise

@Jacajack
Copy link

Jacajack commented Aug 23, 2016

Hi everyone!
I recently came up with an idea, that I'd be nice to have some folders with mime-type based symbols. For example one for C code, and one for JavaScript, and so on...

This is what I mean:
selection_815
I made this yesterday, in like 2 minutes, without any guideline, that's why it's ugly

I can create and contribute some of those, if you think the idea makes sense.

Also, what about colors? Is there some script that generates colorful icons available, or should I create mine? (I found some custom-folder-*.svg icons, I assume those are the base ones)

Ok, I found it 😝

@andia89
Copy link
Contributor

andia89 commented Aug 23, 2016

I guess new folders are ok (and welcome probably) :) Be warned though this is a LOT of work (I actually started to add a new folder and gave up halfway through it. The problem is, that in order to get them merged you need to provide a lot of different sizes (16px, 22px, 24px, 32px, 48px, 64px) and 6 different styles makes a total of 36 distinct icons each aligned to pixel grid.

Then you also need a lot of different colors (this can be scripted though)

So yeah, new folders are cool, but a lot of work

@Jacajack
Copy link

Oh, I didn't realize it's that much work...

Maybe it would be possible to rescale icons with some other script, then only align the symbols in Inkscape? And I believe script for copying symbols over different styles would be useful.

I can try to do this, if that way of developing icons is acceptable ;)

@palob
Copy link
Member

palob commented Aug 23, 2016

You don't need a script for resizing the icons, the folders itself are already present for all sizes :)

@Jacajack
Copy link

Jacajack commented Aug 23, 2016

I meant to say, script for rescaling the new symbols themselves :)

So, what about this?

  • Create SVG file with symbol alone
  • Run script to rescale symbol to all sizes
  • Run another (or even the same one) script to put symbols in the icons
  • Use Inkscape to align 36 symbols
  • Run script to create different color variations of icons

I think that would make the process a little bit easier, than manually rescaling and copying symbols 36 times.

@Jacajack
Copy link

Jacajack commented Aug 24, 2016

Ok, so I made a prototype...

This is how it works:

  • Create single 16x16 symbol, and then optimize it (I used svgo because svgclean was removing my titled group, but that's something I'm going to work on)
    The only requirement is that symbol must be in group with title 'symbol'.
    selection_825
    This is the one I used for testing
  • Run first script to multiply symbol over SVG files of different sizes
    Like this:
    selection_826
    And you get this:
    image
  • Manually rescale and fit symbols like you would do on folder icon in the each file.
  • Run ./paste.pl and it will merge symbols with base folder icons according to paste.json, which looks like this currently:
[
    ["base/48/custom-folder.svg", "symbols/48.svg", "icons/48/custom-folder-test.svg"]
]
  • This is result:
    selection_828
    Of course if you fit it nicely before, this is going to look better
  • Then there are only minor edits left to do, depending on icon size and style

What do you think about this?

Here's code: https://gist.github.com/Jacajack/f1f065c49ce3cae9cf6cc9d85426c9fe
By the way, I'd like to officially announce that I'm going to hell, because I'm parsing SVG files with regular expressions... So, if are Perl programmer, do not go there.

@Foggalong
Copy link
Contributor

If you can get it to work reliably so that the quality is still there, I'd be happy to merge additional folder designs into the repo.

@Foggalong
Copy link
Contributor

Added Android into the list following the closure of #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants