Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

are the internal datasets found in R/sysdata.rda the same datasets that are found in data #71

Closed
ernestguevarra opened this issue Nov 3, 2024 · 5 comments
Assignees
Labels
bug Something isn't working infrastructure question Further information is requested

Comments

@ernestguevarra
Copy link
Member

ernestguevarra commented Nov 3, 2024

When loading the contents of R/sysdata.rda, I see:

mfaz.01
mfaz.02
wfhz.01

There are also datasets in data that have the same names. Are these the same datasets? if so, then it would be more appropriate to have them as internal datasets or exported datasets, not both.

if you decide to keep them internal, then remove the ones inside the data folder and then remove the corresponding documentation for these datasets. Internal datasets do not need documentation.

if you decide to use the datasets in data, then remove R/sysdata.rda

@ernestguevarra ernestguevarra added question Further information is requested infrastructure labels Nov 3, 2024
@ernestguevarra ernestguevarra added this to the 4. Pre-release milestone Nov 3, 2024
@tomaszaba
Copy link
Collaborator

When loading the contents of R/sysdata.rda, I see:

mfaz.01

mfaz.02

wfhz.01

There are also datasets in data that have the same names. Are these the same datasets? if so, then it would be more appropriate to have them as internal datasets or exported datasets, not both.

if you decide to keep them internal, then remove the ones inside the data folder and then remove the corresponding documentation for these datasets. Internal datasets do not need documentation.

if you decide to use the datasets in data, then remove R/sysdata.rda

These files I want to keep them as internal. The exported ones are those I named as anthro.0*.

@ernestguevarra
Copy link
Member Author

If you look at the contents of your data folder in your current branch by issuing this command:

list.files("data")

you will see:

> list.files("data")
[1] "anthro.01.rda" "anthro.02.rda" "anthro.03.rda" "anthro.04.rda" "mfaz.01.rda"   "mfaz.02.rda"  
[7] "wfhz.01.rda"  

@ernestguevarra ernestguevarra added the bug Something isn't working label Nov 3, 2024
@tomaszaba
Copy link
Collaborator

@ernestguevarra I need your help on this.
I tried to fix this bug, but it creates an error in the development workflow. Is the problem related to the fact that I documented the files in R/data.R?

You will not see this error in the PR that I just raised because I cancelled changes made on this.

 > ## With `.from` set to "zscores" ----
   > remove_flags(
   +   x = wfhz.01$wfhz,
   +   .from = "zscores"
   + )
   Error: object 'wfhz.01' not found
   Execution halted

@ernestguevarra
Copy link
Member Author

see this comment that I made to your latest PR.

@tomaszaba
Copy link
Collaborator

see this comment that I made to your latest PR.

Noted. I believe we can consider this issue completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants