Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new typography style system to align with new DNN 10 CSS variables #371

Open
david-poindexter opened this issue May 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@david-poindexter
Copy link
Member

Is your feature request related to a problem?

We'll add a new typography style system to align with new DNN 10 CSS variables.

Describe the solution you'd like

We'll leverage the following from the new DNN 10 theme Aperture to integrate within nvQuickTheme.

$fonts: (
    'base-font-size': 18,
);

$var-base-font-size: #{map-get($fonts, 'base-font-size')};
$lineheight: 1.5;
$base-line-height: calc($var-base-font-size * 1.5);
$defaultlineheight: calc($var-base-font-size * 1.5);

$ubuntu: 'Ubuntu', Helvetica, sans-serif;

///TODO: Remove these in favor of those injected by DNN 10. The defaults in DNN 10 should match these.
:root {
    --dnn-base-font-size: #{map-get($fonts, 'base-font-size')};
}

// Font function
@function font($font-name) {
    @return var(--dnn-#{$font-name}, map-get($fonts, $font-name));
}

Describe alternatives you've considered

n/a

Additional context

Similar to the color system, we'll need to decide whether or not we simply want to consume the CSS variables from DNN 10 or if we want to override them (which would render the administration of the colors in DNN 10 impossible). Most likely we'll just consume them with the understanding that out-of-the-box in DNN 10, only super users will be able to change the values of these CSS variables.

@david-poindexter david-poindexter added the enhancement New feature or request label May 5, 2024
@david-poindexter david-poindexter added this to the 4.0.0 milestone May 5, 2024
@david-poindexter david-poindexter self-assigned this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant