Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-day "datespan" events created in Google Calendar are created as a single day event #413

Open
aaronbski opened this issue Nov 18, 2016 · 2 comments

Comments

@aaronbski
Copy link

aaronbski commented Nov 18, 2016

Sample of the POST:
https://gist.github.com/aaronbski/ba96e8f34cc36f88f3dfe653878a2413

If I retrieve the event from the sync engine, it shows the correct datespan (2016-12-06 to 2016-12-08 in this example), but when I look at the event in Google Calendar I see only a single all day event.

Looks like a quick fix here:
https://github.com/nylas/sync-engine/blob/master/inbox/events/google.py#L566

dump["end"] = {"date": event.start.strftime('%Y-%m-%d')}
should be
dump["end"] = {"date": event.end.strftime('%Y-%m-%d')}

@pfista
Copy link
Contributor

pfista commented Nov 18, 2016

Thanks for submitting this! This will be addressed in our next sync-engine release.

@pfista pfista closed this as completed Nov 18, 2016
@aaronbski
Copy link
Author

I wanted to note that this bug still remains. I've only retested this on the Nylas hosted version as I can't get the vagrant environment to work properly, but I've been told that this fix was pushed to production.

@pfista pfista reopened this Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants