Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer writing to writeBundle() or generateBundle() #7

Open
donmccurdy opened this issue Dec 2, 2022 · 0 comments
Open

Defer writing to writeBundle() or generateBundle() #7

donmccurdy opened this issue Dec 2, 2022 · 0 comments
Labels
code health help wanted Extra attention is needed P3

Comments

@donmccurdy
Copy link
Contributor

The plugin API offers these methods:

https://github.com/nytimes/bundler-plugin-gltf/blob/5b252ca48c11ba97233bb37af96ececc3be90a71/packages/core/core.js#L151-L152

We aren't using them now, writing during calls to load(id). Just based on the names, it sounds like maybe we're supposed to be deferring writes to desk until later, but I haven't seen any issues with the current setup. Low-priority, but we should look into the correct use of the plugin API here.

@donmccurdy donmccurdy added help wanted Extra attention is needed P3 code health labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health help wanted Extra attention is needed P3
Projects
None yet
Development

No branches or pull requests

1 participant