Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes get truncation by word instead of by line #35

Open
jkester1986 opened this issue Dec 15, 2017 · 3 comments
Open

sometimes get truncation by word instead of by line #35

jkester1986 opened this issue Dec 15, 2017 · 3 comments
Labels

Comments

@jkester1986
Copy link

I have noticed sometimes that when my preact component loads to the page, instead of truncating by number of lines it truncates by words. I put the ellipsis call inside componentDidMount() initially, but have tried several other places as well. I only see the issue when loading my component via other components, not when running the demo of my component.

@pnicolli
Copy link
Contributor

Hi @jkester1986 👋
Can you please provide an example of one or two components that we can use to reproduce this? Haven't tried ellipsed with react yet (or preact, or others), but I'm interested in trying it, so I'm willing to look into this issue :)

@nzambello nzambello added the bug label Dec 22, 2017
@nzambello
Copy link
Owner

@jkester1986 Any update?

@jkester1986
Copy link
Author

Sorry, must have missed your first reply. The only time I saw the issue though was when I loaded one component into with another. The child component would truncate incorrectly sometimes in that case. It didn't really matter where I put the ellipsis call. Running a demo on just the child component itself worked perfectly fine. I unfortunately can't give an example of the components because they are things that we built at my place of employment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants