Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Set default select value #61

Closed
motleydev opened this issue Jul 13, 2018 · 1 comment
Closed

Feature Request: Set default select value #61

motleydev opened this issue Jul 13, 2018 · 1 comment

Comments

@motleydev
Copy link

Pass an option parameter to select to indicate which value should be default. Would look something like:

DOM.select(arr, defaultValue)

Something like this should work:

export default function(values, selected) {
  var select = document.createElement("select");
  Array.prototype.forEach.call(values, function(value) {
    var option = document.createElement("option");
    option.value = option.textContent = value;
    if (option.value === selected) option.selected = true; <--------
    select.appendChild(option);
  });
  return select;
}
@mbostock
Copy link
Member

(Duplicate #57.) We’re probably going to deprecate DOM.select and related methods (see #31) in the near future in favor of HTML tagged template literals, so I don’t think it makes sense to add new functionality at this time.

For a static dropdown, I’d say:

html`<select>
  <option value="red">red</option>
  <option value="green" selected>green</option>
  <option value="blue">blue</option>
</select>`

For a data-driven one, something like:

colors = ["red", "green", "blue"]
html`<select>${colors.map(c => `
  <option value="${c}" ${c === "green" ? " selected" : ""}>${c}</option>`)}
</select>`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants