Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why is there a dependency on Base? #2594

Open
hannesm opened this issue Oct 21, 2024 · 1 comment
Open

Question: Why is there a dependency on Base? #2594

hannesm opened this issue Oct 21, 2024 · 1 comment

Comments

@hannesm
Copy link

hannesm commented Oct 21, 2024

I am happy for ocamlformat to exist. I am wondering whether there is any strong reason for depending on base? The reason I'm asking is since compilation times of base and its dependencies are pretty huge, and I'm not sure I see the benefit within ocamlformat to use such an external stdlib.

Any strong reasons for having this dependency? Are there any attempts to remove it? Would a PR removing this dependency be welcome, and would there be resources that it would be reviewed?

@gpetiot
Copy link
Collaborator

gpetiot commented Oct 30, 2024

Historically there was a few early contributions from Jane Street, and ocamlformat needed a lot of utility functions so it made sense at that time to just use base instead of re-implemeting a lot of stuff.

There have been an attempt to remove this dependency in the past, but this was never a priority, and it got stale and aborted because it was a lot of unfunded work. Priorities were decided on whether someone was funding maintenance work or new features. However I think that's something that will be welcomed in the codebase if someone has got the time to put into it.
It would probably be reviewed on contributors' personal time, as any non-funded/non-prioritised work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants