add support for camino Utf8Path and Utf8PathBuf #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also change the github config to run on PRs? |
Oh that's a good idea, yes please. |
oconnor663
reviewed
Mar 1, 2021
Allows testing for changes as they happen.
Add support behind a non-default `"camino"` feature. Closes oconnor663#90.
|
Updated! Sorry about the delay, this looks good to go now (hopefully tests pass) |
|
(Apologies, I've had a busy time at work and built up a backlog of reviews on personal projects. But I haven't forgotten about this!) |
|
This is maybe obvious, but until we have this feature, the workaround is to use let echo = Utf8Path::new("/bin/echo");
cmd!(echo.as_str(), "hi").run().unwrap(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support behind a non-default
"camino"feature.Closes #90.
(One question I have is whether the feature should be called
caminoorcamino1. I personally prefer baking in the semver major version into the feature name but opinions vary.)