Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ot_spinner: replace num_active_spinner, onloaded, and when_loaded with a spinner returning a Lwt thread waking up when loaded. #133

Open
sagotch opened this issue Apr 5, 2017 · 0 comments

Comments

@sagotch
Copy link
Contributor

sagotch commented Apr 5, 2017

(** the number of spinners currently spinning *)
val num_active_spinners : int Eliom_shared.React.S.t
(** [onloaded] is an event that fires when all spinners have finished loading.
    This can occur multiple times. *)
val onloaded : unit Eliom_shared.React.E.t
(** do an action once no spinners are spinning (could be right away) *)
val when_loaded : (unit -> unit) -> unit

Instead of using these functions, which are not firing when we want them to be firing (e.g. the when_loaded event is used to setup form while it actually wait for every spinner to terminate), add a version of the function returning a unit Lwt.t to signal that content has been loaded.

@sagotch sagotch changed the title Ot_spinner: replace num_active_spinner, onloaded, and when_loaded with a spinner returning the Lwt thread woke up when loaded. Ot_spinner: replace num_active_spinner, onloaded, and when_loaded with a spinner returning a Lwt thread waking up when loaded. Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant