Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker updates broken after refactored locking implementation #2130

Open
Viren6 opened this issue Aug 17, 2024 · 0 comments · May be fixed by #2131
Open

Worker updates broken after refactored locking implementation #2130

Viren6 opened this issue Aug 17, 2024 · 0 comments · May be fixed by #2131
Labels
bug worker update code changes requiring a worker update

Comments

@Viren6
Copy link

Viren6 commented Aug 17, 2024

After an update is pushed, workers repeatedly print:

*** Another worker (with PID=7) is already running in this directory ***

This hasn't been discovered yet on the main instance since there have been no worker updates since its introduction.
The reason this is occuring is because the worker lock is not being released before the restart.
@Viren6 Viren6 linked a pull request Aug 17, 2024 that will close this issue
Open
@ppigazzini ppigazzini added bug worker update code changes requiring a worker update labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug worker update code changes requiring a worker update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix worker updates Viren6/fishtest
2 participants
@ppigazzini @Viren6